fix: prevent accidental sheet dismissal when tapping amount#756
Merged
fix: prevent accidental sheet dismissal when tapping amount#756
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #648
This PR removes the tap action from the balance header on the received/sent confetti sheet to prevent unintended sheet dismissal.
Description
When receiving or sending a payment, the confetti sheet displays a balance header showing the transaction amount. Previously, tapping this amount would close the sheet, which was confusing and unexpected. On iOS, this same interaction swaps between bitcoin and fiat display. This fix removes the
onClickhandler from theBalanceHeaderViewinNewTransactionSheetto match expected behavior.Preview
receive.webm
send.webm
QA Notes
1. Tap amount on received confetti sheet
2. Tap amount on sent confetti sheet
3. Regression - Sheet dismissal